Re: [PATCH v6 16/40] spi: ep93xx: add DT support for Cirrus EP93xx
From: Andy Shevchenko
Date: Wed Dec 13 2023 - 13:13:23 EST
On Tue, Dec 12, 2023 at 11:20:33AM +0300, Nikita Shubin wrote:
> - add OF ID match table
> - add device tree DMA request, so we can probe defer, in case DMA is not
> ready yet
> - drop DMA platform code
...
> + espi->dma_rx = dma_request_chan(dev, "rx");
> + if (IS_ERR(espi->dma_rx)) {
> + ret = PTR_ERR(espi->dma_rx);
> + dev_err_probe(dev, ret, "rx DMA setup failed");
ret = dev_err_probe(...);
> goto fail_free_page;
> }
...
> + espi->dma_tx = dma_request_chan(dev, "tx");
> + if (IS_ERR(espi->dma_tx)) {
> + ret = PTR_ERR(espi->dma_tx);
> + dev_err_probe(dev, ret, "tx DMA setup failed");
Ditto.
> goto fail_release_rx;
> }
...
Otherwise LGTM.
--
With Best Regards,
Andy Shevchenko