Re: [PATCH v7 03/24] x86/resctrl: Create helper for RMID allocation and mondata dir creation

[James Morse]

Hi Babu,

On 09/11/2023 20:28, Moger, Babu wrote:
> On 10/25/23 13:03, James Morse wrote:
>> When monitoring is supported, each monitor and control group is allocated
>> an RMID. For control groups, rdtgroup_mkdir_ctrl_mon() later goes on to
>> allocate the CLOSID.
>>
>> MPAM's equivalent of RMID are not an independent number, so can't be
>> allocated until the CLOSID is known. An RMID allocation for one CLOSID
>> may fail, whereas another may succeed depending on how many monitor
>> groups a control group has.
>>
>> The RMID allocation needs to move to be after the CLOSID has been
>> allocated.
>>
>> Move the RMID allocation and mondata dir creation to a helper, this
>> makes a subsequent change easier to read.
>>
>> Tested-by: Peter Newman <peternewman@xxxxxxxxxx>
>> Tested-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxx>
>> Reviewed-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxx>
>> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
>> Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
>> Signed-off-by: James Morse <james.morse@xxxxxxx>
> 
> Reviewed-by: Babu Moger <babu.moger@xxxxxxx>

Thanks!


James