Re: [PATCH v5 1/5] block: Fix bio IO priority setting

From: Mike Snitzer
Date: Wed Dec 13 2023 - 12:42:51 EST


On Wed, Dec 13 2023 at 5:42P -0500,
Hongyu Jin <hongyu.jin.cn@xxxxxxxxx> wrote:

> From: Hongyu Jin <hongyu.jin@xxxxxxxxxx>
>
> Move bio_set_ioprio() into submit_bio():
> 1. Only call bio_set_ioprio() once to set the priority of original bio,
> the bio that cloned and splited from original bio will auto inherit
> the priority of original bio in clone process.
>
> 2. The IO priority can be passed to module that implement
> struct gendisk::fops::submit_bio, help resolve some
> of the IO priority loss issues.
>
> This patch depends on commit 82b74cac2849 ("blk-ioprio: Convert from
> rqos policy to direct call")
>
> Fixes: a78418e6a04c ("block: Always initialize bio IO priority on submit")
>
> Co-developed-by: Yibin Ding <yibin.ding@xxxxxxxxxx>
> Signed-off-by: Yibin Ding <yibin.ding@xxxxxxxxxx>
> Signed-off-by: Hongyu Jin <hongyu.jin@xxxxxxxxxx>

Would be nice to get this block core fix upstream ASAP independent of
your various DM changes.

Please simplify this patch's header like was requested in review of v4:
https://patchwork.kernel.org/project/dm-devel/patch/20231212111150.18155-2-hongyu.jin.cn@xxxxxxxxx/