Re: [PATCH v6 03/40] ARM: ep93xx: add regmap aux_dev
From: Andy Shevchenko
Date: Wed Dec 13 2023 - 12:29:09 EST
On Tue, Dec 12, 2023 at 11:20:20AM +0300, Nikita Shubin wrote:
> The following driver's should be instantiated by ep93xx syscon driver:
>
> - reboot
> - pinctrl
> - clock
>
> They all require access to DEVCFG register with a shared lock held, to
> avoid conflict writing to swlocked parts of DEVCFG.
>
> Provide common resources such as base, regmap and spinlock via auxiliary
> bus framework.
...
> struct platform_device;
> +struct regmap;
Perhaps more to add. See below.
...
> +enum ep93xx_soc_model {
> + EP93XX_9301_SOC,
> + EP93XX_9307_SOC,
> + EP93XX_9312_SOC
It doesn't look like a termination, so leave trailing comma.
> +};
...
> +#include <linux/spinlock.h>
I don't see a user for this. Am I missing something?
--
With Best Regards,
Andy Shevchenko