RE: [Patch v6 00/10] Add MFC v12 support

[Alim Akhtar]

> -----Original Message-----
> From: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx>
> Sent: Wednesday, December 13, 2023 1:41 PM
> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> Cc: m.szyprowski@xxxxxxxxxxx; andrzej.hajda@xxxxxxxxx;
> mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx;
> andi@xxxxxxxxxxx; gost.dev@xxxxxxxxxxx; alim.akhtar@xxxxxxxxxxx;
> aswani.reddy@xxxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx;
> ajaykumar.rs@xxxxxxxxxxx; aakarsh.jain@xxxxxxxxxxx
> Subject: [Patch v6 00/10] Add MFC v12 support
> 
> This patch series adds MFC v12 support. MFC v12 is used in Tesla FSD SoC.
> 
> This adds support for following:
> 
> -Add support for YV12 and I420 format (3-plane) -Add support for Rate
> Control, UHD and DMABUF for encoder -Add support for DPB buffers
> allocation based on MFC requirement
> 
> changes since v5:
> -As per Krzysztof, he will take MFC dt-entries patch via Samsung SoC once dt-
> bindings patch gets accepted. Therefore, excluded MFC dt-entries patch
> from v6.
> -Addressed review comments by Hans Verkuil.
> Resolved smatch warning from 'drivers/media/platform/samsung/s5p-
> mfc/s5p_mfc_enc.c'.
> Resolved kernel doc warnings from 'drivers/media/platform/samsung/s5p-
> mfc/s5p_mfc_common.h'.
> Added explanation in the patch 9 as comment on why mfc v12 firmware
> loading is needed for each run.
> v5 link: https://patchwork.kernel.org/project/linux-
> media/cover/20231206063045.97234-1-aakarsh.jain@xxxxxxxxxxx/
> 
[snip]
> Aakarsh Jain (10):
>   dt-bindings: media: s5p-mfc: Add mfcv12 variant
>   media: s5p-mfc: Rename IS_MFCV10 macro
>   media: s5p-mfc: Add initial support for MFCv12
>   media: s5p-mfc: Add YV12 and I420 multiplanar format support
>   media: s5p-mfc: Add support for rate controls in MFCv12
>   media: s5p-mfc: Add support for UHD encoding.
>   media: s5p-mfc: Add support for DMABUF for encoder
>   media: s5p-mfc: Set context for valid case before calling try_run
>   media: s5p-mfc: Load firmware for each run in MFCv12.
>   media: s5p-mfc: DPB Count Independent of VIDIOC_REQBUF
> 
>  .../bindings/media/samsung,s5p-mfc.yaml       |  18 ++
>  .../platform/samsung/s5p-mfc/regs-mfc-v12.h   |  52 +++
>  .../platform/samsung/s5p-mfc/regs-mfc-v7.h    |   1 +
>  .../platform/samsung/s5p-mfc/regs-mfc-v8.h    |   3 +
>  .../media/platform/samsung/s5p-mfc/s5p_mfc.c  |  36 ++-
> .../platform/samsung/s5p-mfc/s5p_mfc_common.h |  33 +-
>  .../platform/samsung/s5p-mfc/s5p_mfc_ctrl.c   |  15 +-
>  .../platform/samsung/s5p-mfc/s5p_mfc_dec.c    |  60 +++-
>  .../platform/samsung/s5p-mfc/s5p_mfc_enc.c    | 149 ++++++---
>  .../platform/samsung/s5p-mfc/s5p_mfc_opr.h    |  14 +-
>  .../platform/samsung/s5p-mfc/s5p_mfc_opr_v5.c |  12 +-
> .../platform/samsung/s5p-mfc/s5p_mfc_opr_v6.c | 299 ++++++++++++++---
> -
>  .../platform/samsung/s5p-mfc/s5p_mfc_opr_v6.h |   7 +-
>  13 files changed, 550 insertions(+), 149 deletions(-)  create mode 100644
> drivers/media/platform/samsung/s5p-mfc/regs-mfc-v12.h
> 
Tested this series on FSD platform, feel free to add
Tested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> --
> 2.17.1