Re: [PATCH 3/4] gpiolib: cdev: reduce locking in gpio_desc_to_lineinfo()

[Andy Shevchenko]

On Wed, Dec 13, 2023 at 10:07:28PM +0800, Kent Gibson wrote:
> On Wed, Dec 13, 2023 at 03:56:27PM +0200, Andy Shevchenko wrote:
> > On Tue, Dec 12, 2023 at 01:42:52PM +0800, Kent Gibson wrote:

...

> > > -	unsigned long flags;
> > > +	unsigned long iflags, dflags;
> >
> > With a preliminary conversion to cleanup.h this whole change becomes cleaner,
> > no?
> 
> You mean the scoped guards?  Dunno - haven't used them.
> Care to provide more detail?

Yes.

With use of those the flags will gone and you won't need iflags,
which is non-standard name for the spin lock flags variable anyway,
at all. Only new dflags will come here.

-- 
With Best Regards,
Andy Shevchenko