Re: [PATCH] mei: fix vsc dependency

[Arnd Bergmann]

On Wed, Dec 13, 2023, at 14:12, Sakari Ailus wrote:
> On Wed, Dec 13, 2023 at 01:43:05PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>> 
>> The Kconfig dependency in the new module is reversed from the dependency
>> on the exported symbols, so it fails to link with CONFIG_INTEL_MEI_VSC
>> disabled and CONFIG_INTEL_MEI_VSC_HW enabled:
>> @@ -64,6 +64,7 @@ config INTEL_MEI_VSC_HW
>>  	tristate "Intel visual sensing controller device transport driver"
>>  	depends on ACPI && SPI
>>  	depends on GPIOLIB || COMPILE_TEST
>> +	depends on INTEL_MEI_VSC
>
> Oops. The dependency indeed seems to have been reversed.
>
> Could you also reorder the entries so the one that depends on the other
> would be below?

Update: I actually misread the code and the original dependency
appears to have been correct. Instead there is a different bug,
so I'll send a new patch after I have done enough testing on
the new version.

      Armd