Re: [PATCH mm 1/4] lib/stackdepot: add printk_deferred_enter/exit guards

From: Andrey Konovalov
Date: Wed Dec 13 2023 - 09:41:59 EST


On Tue, Dec 12, 2023 at 9:57 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, 12 Dec 2023 19:59:29 +0100 Marco Elver <elver@xxxxxxxxxx> wrote:
>
> > On Tue, 12 Dec 2023 at 01:14, <andrey.konovalov@xxxxxxxxx> wrote:
> > >
> > > From: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
> > >
> > > Stack depot functions can be called from various contexts that do
> > > allocations, including with console locks taken. At the same time, stack
> > > depot functions might print WARNING's or refcount-related failures.
> > >
> > > This can cause a deadlock on console locks.
> > >
> > > Add printk_deferred_enter/exit guards to stack depot to avoid this.
> > >
> > > Reported-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> > > Closes: https://lore.kernel.org/all/000000000000f56750060b9ad216@xxxxxxxxxx/
> > > Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
> >
> > Reviewed-by: Marco Elver <elver@xxxxxxxxxx>
> >
> > Doesn't need Fixes, because the series is not yet in mainline, right?
>
> I've moved the series "stackdepot: allow evicting stack traces, v4"
> (please, not "the stack depot eviction series") into mm-nonmm-stable.
> Which is allegedly non-rebasing.
>
> So yes please, provide Fixes: on each patch.

Sure, I'll add them when I mail v2 after we figure out what to do with
patch #2. Thanks!