[tip: x86/cleanups] x86/head_64: Use TESTB instead of TESTL in secondary_startup_64_no_verify()

From: tip-bot2 for Uros Bizjak
Date: Wed Dec 13 2023 - 08:00:15 EST


The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID: 7d28365a06af74cee015a448d32ab6e98cd05cfb
Gitweb: https://git.kernel.org/tip/7d28365a06af74cee015a448d32ab6e98cd05cfb
Author: Uros Bizjak <ubizjak@xxxxxxxxx>
AuthorDate: Thu, 09 Nov 2023 21:09:56 +01:00
Committer: Borislav Petkov (AMD) <bp@xxxxxxxxx>
CommitterDate: Wed, 13 Dec 2023 13:35:38 +01:00

x86/head_64: Use TESTB instead of TESTL in secondary_startup_64_no_verify()

There is no need to use TESTL when checking the least-significant bit
with a TEST instruction. Use TESTB, which is three bytes shorter:

f6 05 00 00 00 00 01 testb $0x1,0x0(%rip)

vs:

f7 05 00 00 00 00 01 testl $0x1,0x0(%rip)
00 00 00

for the same effect.

No functional changes intended.

Signed-off-by: Uros Bizjak <ubizjak@xxxxxxxxx>
Signed-off-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>
Link: https://lore.kernel.org/r/20231109201032.4439-1-ubizjak@xxxxxxxxx
---
arch/x86/kernel/head_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
index 086a2c3..1f79d80 100644
--- a/arch/x86/kernel/head_64.S
+++ b/arch/x86/kernel/head_64.S
@@ -182,7 +182,7 @@ SYM_INNER_LABEL(secondary_startup_64_no_verify, SYM_L_GLOBAL)
/* Enable PAE mode, PSE, PGE and LA57 */
orl $(X86_CR4_PAE | X86_CR4_PSE | X86_CR4_PGE), %ecx
#ifdef CONFIG_X86_5LEVEL
- testl $1, __pgtable_l5_enabled(%rip)
+ testb $1, __pgtable_l5_enabled(%rip)
jz 1f
orl $X86_CR4_LA57, %ecx
1: