[PATCH] mei: fix vsc dependency

From: Arnd Bergmann
Date: Wed Dec 13 2023 - 07:43:19 EST


From: Arnd Bergmann <arnd@xxxxxxxx>

The Kconfig dependency in the new module is reversed from the dependency
on the exported symbols, so it fails to link with CONFIG_INTEL_MEI_VSC
disabled and CONFIG_INTEL_MEI_VSC_HW enabled:

ERROR: modpost: "vsc_tp_reset" [drivers/misc/mei/mei-vsc.ko] undefined!
ERROR: modpost: "vsc_tp_init" [drivers/misc/mei/mei-vsc.ko] undefined!
ERROR: modpost: "vsc_tp_xfer" [drivers/misc/mei/mei-vsc.ko] undefined!
ERROR: modpost: "vsc_tp_need_read" [drivers/misc/mei/mei-vsc.ko] undefined!
ERROR: modpost: "vsc_tp_intr_enable" [drivers/misc/mei/mei-vsc.ko] undefined!
ERROR: modpost: "vsc_tp_intr_synchronize" [drivers/misc/mei/mei-vsc.ko] undefined!
ERROR: modpost: "vsc_tp_intr_disable" [drivers/misc/mei/mei-vsc.ko] undefined!
ERROR: modpost: "vsc_tp_register_event_cb" [drivers/misc/mei/mei-vsc.ko] undefined!

Make the dependency reflect the module dependency.

Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
---
drivers/misc/mei/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig
index 858bd701d68c..eb69987f8325 100644
--- a/drivers/misc/mei/Kconfig
+++ b/drivers/misc/mei/Kconfig
@@ -64,6 +64,7 @@ config INTEL_MEI_VSC_HW
tristate "Intel visual sensing controller device transport driver"
depends on ACPI && SPI
depends on GPIOLIB || COMPILE_TEST
+ depends on INTEL_MEI_VSC
help
Intel SPI transport driver between host and Intel visual sensing
controller (IVSC) device.
@@ -73,7 +74,6 @@ config INTEL_MEI_VSC_HW

config INTEL_MEI_VSC
tristate "Intel visual sensing controller device with ME interface"
- depends on INTEL_MEI_VSC_HW
depends on INTEL_MEI
help
Intel MEI over SPI driver for Intel visual sensing controller
--
2.39.2