Re: [PATCH v2 03/16] fs/bdev: Add atomic write support info to statx

[John Garry]

On 13/12/2023 10:24, Jan Kara wrote:
> > Signed-off-by: Prasad Singamsetty<prasad.singamsetty@xxxxxxxxxx>
> > Signed-off-by: John Garry<john.g.garry@xxxxxxxxxx>
> Just some nits below.
>
> > +#define BDEV_STATX_SUPPORTED_MSK (STATX_DIOALIGN | STATX_WRITE_ATOMIC)
>                                  ^^^
> 				I believe saving one letter here is not
> really beneficial so just spell out MASK here...

ok

> >   /*
> > - * Handle STATX_DIOALIGN for block devices.
> > - *
> > - * Note that the inode passed to this is the inode of a block device node file,
> > - * not the block device's internal inode.  Therefore it is*not*  valid to use
> > - * I_BDEV() here; the block device has to be looked up by i_rdev instead.
> > + * Handle STATX_{DIOALIGN, WRITE_ATOMIC} for block devices.
> >    */
> Please keep "Note ..." from the above comment (or you can move the note in
> front of blkdev_get_no_open() if you want).

ok, fine, I think that moving it to in front of blkdev_get_no_open() may 
be best.

Thanks,
John