Re: [PATCH 1/3] arm64: dts: ti: k3-am65: Add additional regs for DMA components

[Jai Luthra]

Hi Vignesh/Manorit,

Thanks for the patch. BCDMA regions don't seem to match the TRM for 
AM65, can you recheck?

On Dec 12, 2023 at 16:46:32 +0530, Vignesh Raghavendra wrote:
> From: Manorit Chawdhry <m-chawdhry@xxxxxx>
> 
> Add additional reg properties for UDMA and RingAcc nodes which are
> mostly used by bootloader components before Device Manager firmware
> services are available, in order to setup DMA transfers.
> 
> Signed-off-by: Manorit Chawdhry <m-chawdhry@xxxxxx>
> Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 8 ++++++--
>  arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi  | 8 ++++++--
>  2 files changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 5ebb87f467de..2033a8ec89d6 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -790,8 +790,12 @@ main_udmap: dma-controller@31150000 {
>  			compatible = "ti,am654-navss-main-udmap";
>  			reg = <0x0 0x31150000 0x0 0x100>,
>  			      <0x0 0x34000000 0x0 0x100000>,
> -			      <0x0 0x35000000 0x0 0x100000>;
> -			reg-names = "gcfg", "rchanrt", "tchanrt";
> +			      <0x0 0x35000000 0x0 0x100000>,
> +			      <0x0 0x30b00000 0x0 0x20000>,

AM65 TRM mentions TCHAN region size as 0x10000 in the memory map. Can 
you confirm if this is correct and send a v2 if not?

> +			      <0x0 0x30c00000 0x0 0x8000>,

Same here, TRM says size is 0x10000.

> +			      <0x0 0x30d00000 0x0 0x4000>;

Same here, TRM says size is 0x8000.

> +			reg-names = "gcfg", "rchanrt", "tchanrt",
> +				    "tchan", "rchan", "rflow";
>  			msi-parent = <&inta_main_udmass>;
>  			#dma-cells = <1>;
>  
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> index edd5cfbec40e..ecd7356f3315 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> @@ -214,8 +214,12 @@ mcu_udmap: dma-controller@285c0000 {
>  			compatible = "ti,am654-navss-mcu-udmap";
>  			reg = <0x0 0x285c0000 0x0 0x100>,
>  			      <0x0 0x2a800000 0x0 0x40000>,
> -			      <0x0 0x2aa00000 0x0 0x40000>;
> -			reg-names = "gcfg", "rchanrt", "tchanrt";
> +			      <0x0 0x2aa00000 0x0 0x40000>,
> +			      <0x0 0x284a0000 0x0 0x4000>,
> +			      <0x0 0x284c0000 0x0 0x4000>,
> +			      <0x0 0x28400000 0x0 0x2000>;

These look okay.

> +			reg-names = "gcfg", "rchanrt", "tchanrt",
> +				    "tchan", "rchan", "rflow";
>  			msi-parent = <&inta_main_udmass>;
>  			#dma-cells = <1>;
>  
> -- 
> 2.43.0
> 
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

Attachment: signature.asc
Description: PGP signature