Re: RTL8152_INACCESSIBLE was Re: [PATCH 6.1 000/194] 6.1.68-rc1 review

[Greg Kroah-Hartman]

On Wed, Dec 13, 2023 at 08:52:25AM +0100, Pavel Machek wrote:
> Hi!
> 
> > > > This is the start of the stable review cycle for the 6.1.68 release.
> > > > There are 194 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > 
> > > 
> > > > Douglas Anderson <dianders@xxxxxxxxxxxx>
> > > >      r8152: Add RTL8152_INACCESSIBLE to r8153_aldps_en()
> > > > 
> > > > Douglas Anderson <dianders@xxxxxxxxxxxx>
> > > >      r8152: Add RTL8152_INACCESSIBLE to r8153_pre_firmware_1()
> > > > 
> > > > Douglas Anderson <dianders@xxxxxxxxxxxx>
> > > >      r8152: Add RTL8152_INACCESSIBLE to r8156b_wait_loading_flash()
> > > > 
> > > > Douglas Anderson <dianders@xxxxxxxxxxxx>
> > > >      r8152: Add RTL8152_INACCESSIBLE checks to more loops
> > > > 
> > > > Douglas Anderson <dianders@xxxxxxxxxxxx>
> > > >      r8152: Rename RTL8152_UNPLUG to RTL8152_INACCESSIBLE
> > > 
> > > Central patch that actually fixes something is:
> > > 
> > > commit d9962b0d42029bcb40fe3c38bce06d1870fa4df4
> > > Author: Douglas Anderson <dianders@xxxxxxxxxxxx>
> > > Date:   Fri Oct 20 14:06:59 2023 -0700
> > > 
> > >      r8152: Block future register access if register access fails
> > > 
> > > ...but we don't have that in 6.1. So we should not need the rest,
> > > either.
> > > 
> > 
> > Also, the missing patch is fixed subsequently by another patch, so it can not
> > be added on its own.
> 
> For the record I'm trying to advocate "drop all patches listed as they
> don't fix the bug", not "add more", as this does not meet stable
> criteria.

But the original commit here does say it fixes a bug, see the text of
the commits listed above.  So perhaps someone got this all wrong when
they wrote the original commits that got merged into 6.7-rc?  Otherwise
this seems like they are sane to keep for now, unless the original
author says they should be dropped, or someone who can test this driver
says something went wrong.

thanks,

greg k-h