Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test

[John Hubbard]

On 12/12/23 07:12, Mark Brown wrote:
> On Mon, Dec 11, 2023 at 12:29:58PM -0800, John Hubbard wrote:
> > On 12/11/23 12:21, Mark Brown wrote:
...
> > Or maybe there is an innovative way to do all of this, that we have
> > yet to think of.
>
> We do copy files into tools/include at random times which makes sense
> for things that aren't uapi, and we are putting bits of uapi there
> already so we could just expand the set of files copied there.  AFAICT
> the only reason we're copying the uapi files at all is that they're
> directly in the same include/ directories as everything else and are
> always referenced with their uapi/ prefix.

Oh, this sounds like it would work nicely. No more "make headers"
required (hooray!). Instead, the new approach would be "selftests are
allowed to include from tools/include", and then we can just start
copying the files that we need to that location, and gradually fix up
all the selftests.

I really like this, at first reading anyway.

Muhammad, Shuah, others, what do you think?

+Cc: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>


thanks,
--
John Hubbard
NVIDIA