Re: [PATCH v1 1/2] thermal/debugfs: Add thermal cooling device debugfs information

From: kernel test robot
Date: Tue Dec 12 2023 - 20:52:51 EST


Hi Daniel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rafael-pm/thermal]
[also build test WARNING on linus/master v6.7-rc5 next-20231212]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Lezcano/thermal-debugfs-Add-thermal-debugfs-information-for-mitigation-episodes/20231213-001321
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link: https://lore.kernel.org/r/20231212161047.1631077-1-daniel.lezcano%40linaro.org
patch subject: [PATCH v1 1/2] thermal/debugfs: Add thermal cooling device debugfs information
config: arm-defconfig (https://download.01.org/0day-ci/archive/20231213/202312130936.rLIRgZBE-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231213/202312130936.rLIRgZBE-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312130936.rLIRgZBE-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

In file included from drivers/thermal/thermal_core.c:27:
In file included from drivers/thermal/thermal_core.h:16:
>> drivers/thermal/thermal_debugfs.h:10:74: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
static inline void thermal_debug_cdev_add(struct thermal_cooling_device *) {}
^
drivers/thermal/thermal_debugfs.h:11:77: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
static inline void thermal_debug_cdev_remove(struct thermal_cooling_device *) {}
^
drivers/thermal/thermal_debugfs.h:12:81: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
static inline void thermal_debug_cdev_transition(struct thermal_cooling_device *, int) {}
^
drivers/thermal/thermal_debugfs.h:12:86: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
static inline void thermal_debug_cdev_transition(struct thermal_cooling_device *, int) {}
^
4 warnings generated.
--
In file included from drivers/thermal/thermal_helpers.c:22:
In file included from drivers/thermal/thermal_core.h:16:
>> drivers/thermal/thermal_debugfs.h:10:74: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
static inline void thermal_debug_cdev_add(struct thermal_cooling_device *) {}
^
drivers/thermal/thermal_debugfs.h:11:77: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
static inline void thermal_debug_cdev_remove(struct thermal_cooling_device *) {}
^
drivers/thermal/thermal_debugfs.h:12:81: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
static inline void thermal_debug_cdev_transition(struct thermal_cooling_device *, int) {}
^
drivers/thermal/thermal_debugfs.h:12:86: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
static inline void thermal_debug_cdev_transition(struct thermal_cooling_device *, int) {}
^
>> drivers/thermal/thermal_helpers.c:154:6: warning: no previous prototype for function 'thermal_set_delay_jiffies' [-Wmissing-prototypes]
void thermal_set_delay_jiffies(unsigned long *delay_jiffies, int delay_ms)
^
drivers/thermal/thermal_helpers.c:154:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void thermal_set_delay_jiffies(unsigned long *delay_jiffies, int delay_ms)
^
static
5 warnings generated.
--
In file included from drivers/thermal/tegra/soctherm.c:36:
In file included from drivers/thermal/tegra/../thermal_core.h:16:
>> drivers/thermal/tegra/../thermal_debugfs.h:10:74: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
static inline void thermal_debug_cdev_add(struct thermal_cooling_device *) {}
^
drivers/thermal/tegra/../thermal_debugfs.h:11:77: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
static inline void thermal_debug_cdev_remove(struct thermal_cooling_device *) {}
^
drivers/thermal/tegra/../thermal_debugfs.h:12:81: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
static inline void thermal_debug_cdev_transition(struct thermal_cooling_device *, int) {}
^
drivers/thermal/tegra/../thermal_debugfs.h:12:86: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
static inline void thermal_debug_cdev_transition(struct thermal_cooling_device *, int) {}
^
4 warnings generated.


vim +10 drivers/thermal/thermal_debugfs.h

2
3 #ifdef CONFIG_THERMAL_DEBUGFS
4 void thermal_debug_init(void);
5 void thermal_debug_cdev_add(struct thermal_cooling_device *cdev);
6 void thermal_debug_cdev_remove(struct thermal_cooling_device *cdev);
7 void thermal_debug_cdev_transition(struct thermal_cooling_device *cdev, int state);
8 #else
9 static inline void thermal_debug_init(void) {}
> 10 static inline void thermal_debug_cdev_add(struct thermal_cooling_device *) {}

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki