Re: [PATCH v1 1/8] dt-bindings: arm: aspeed: add IBM system1-bmc

[Ninad Palsule]

Hello Conor,

On 12/12/23 11:09, Conor Dooley wrote:
> On Tue, Dec 12, 2023 at 10:39:57AM -0600, Ninad Palsule wrote:
> > Document the new compatibles used on IBM system1-bmc
> >
> > Tested:
> >      This board is tested using the simics simulator.
> I don't see how this is relevant to dt-bindings patches.
Make sense. Removed it.
> > Signed-off-by: Ninad Palsule <ninad@xxxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> >   Documentation/devicetree/bindings/trivial-devices.yaml   | 2 ++
> IMO these should be split into two patches.

Make sense. Split it into two patches.

Thank you for the review.

Thanks & Regards,

Ninad

> Cheers,
> Conor.
>
> >   2 files changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > index 6f7543463d89..ebebe14c42aa 100644
> > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > @@ -85,6 +85,7 @@ properties:
> >                 - facebook,yosemite4-bmc
> >                 - ibm,everest-bmc
> >                 - ibm,rainier-bmc
> > +              - ibm,system1-bmc
> >                 - ibm,tacoma-bmc
> >                 - inventec,starscream-bmc
> >                 - inventec,transformer-bmc
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index 441b55723675..b12a60d2eb0f 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -135,6 +135,8 @@ properties:
> >             - ibm,cffps1
> >               # IBM Common Form Factor Power Supply Versions 2
> >             - ibm,cffps2
> > +            # Infineon barometric pressure and temperature sensor
> > +          - infineon,dps310
> >               # Infineon IR36021 digital POL buck controller
> >             - infineon,ir36021
> >               # Infineon IR38060 Voltage Regulator
> > --
> > 2.39.2