Re: [PATCH mm 4/4] lib/stackdepot: fix comment in include/linux/stackdepot.h

From: Marco Elver
Date: Tue Dec 12 2023 - 14:31:06 EST


On Tue, 12 Dec 2023 at 01:14, <andrey.konovalov@xxxxxxxxx> wrote:
>
> From: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
>
> As stack traces can now be evicted from the stack depot, remove the
> comment saying that they are never removed.
>
> Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx>

Reviewed-by: Marco Elver <elver@xxxxxxxxxx>

> ---
>
> Can be squashed into "lib/stackdepot: allow users to evict stack traces"
> or left standalone.
> ---
> include/linux/stackdepot.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h
> index a6796f178913..adcbb8f23600 100644
> --- a/include/linux/stackdepot.h
> +++ b/include/linux/stackdepot.h
> @@ -11,8 +11,6 @@
> * SLUB_DEBUG needs 256 bytes per object for that). Since allocation and free
> * stack traces often repeat, using stack depot allows to save about 100x space.
> *
> - * Stack traces are never removed from the stack depot.
> - *
> * Author: Alexander Potapenko <glider@xxxxxxxxxx>
> * Copyright (C) 2016 Google, Inc.
> *
> --
> 2.25.1
>