Re: [PATCH net-next v14 09/13] rtase: Implement pci_driver suspend and resume function

From: Jakub Kicinski
Date: Tue Dec 12 2023 - 14:19:14 EST


On Fri, 8 Dec 2023 17:47:29 +0800 Justin Lai wrote:
> +static int rtase_suspend(struct device *device)
> +{
> + struct net_device *dev = dev_get_drvdata(device);
> +
> + if (netif_running(dev)) {
> + netif_stop_queue(dev);
> + netif_device_detach(dev);

detach stops the queue, you don't have to call both

> + rtase_hw_reset(dev);