Re: [PATCH net-next v2] net: mvpp2: add support for mii

[Marcin Wojtas]

Hi,

wt., 12 gru 2023 o 17:07 Maxime Chevallier
<maxime.chevallier@xxxxxxxxxxx> napisał(a):
>
> Hi Stefan,
>
> On Tue, 12 Dec 2023 15:12:00 +0100
> Stefan Eichenberger <eichest@xxxxxxxxx> wrote:
>
> > Currently, mvpp2 only supports RGMII. This commit adds support for MII.
> > The description in Marvell's functional specification seems to be wrong.
> > To enable MII, we need to set GENCONF_CTRL0_PORT3_RGMII, while for RGMII
> > we need to clear it. This is also how U-Boot handles it.
> >
> > Signed-off-by: Stefan Eichenberger <eichest@xxxxxxxxx>
>
> Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>

LGTM, as well.
Reviewed-by: Marcin Wojtas <mw@xxxxxxxxxxxx>

Best regards,
Marcin