Re: [PATCH v2] watchdog: rti_wdt: Drop RPM count when unused

From: Guenter Roeck
Date: Tue Dec 12 2023 - 10:28:33 EST


On 11/21/23 20:16, Vignesh Raghavendra wrote:
Do a RPM put if watchdog is not already started during probe and re
enable it in watchdog start.

On K3 SoCs, watchdogs and their corresponding CPUs are under same PD, so
if the reference count of unused watchdogs aren't dropped, it will lead
to CPU hotplug failures as Device Management firmware won't allow to
turn off the PD due to dangling reference count.

Fixes: 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support")
Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>

I always find it amazing that people think everyone would understand the TLAs
(three-letter-acronyms) they use. While those who don't might find it confusing
why a watchdog driver would need or want to drop rotation-per-minute counts,
and what that has to do with police departments, that isn't worth
arguing about

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Guenter