Re: [PATCH V2 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes

[Krzysztof Kozlowski]

On 12/12/2023 14:32, Om Prakash Singh wrote:
> Add the QCE and Crypto BAM DMA nodes.
> 
> Signed-off-by: Om Prakash Singh <quic_omprsing@xxxxxxxxxxx>
> ---
> 
> Changes in V2:
>   - Update DT node sequence as per register ascending order

Hm, I don't see it...

>   - Fix DT node properties as per convention
> 
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 66f1eb83cca7..7b705df21f4e 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2272,6 +2272,28 @@ ipa: ipa@1e40000 {
>  			status = "disabled";
>  		};
>  
> +		cryptobam: dma-controller@1dc4000 {

It still looks like not correctly ordered by unit address against other
nodes in the file.




Best regards,
Krzysztof