Re: [PATCH linux-next] kernel/power: Use kmap_local_page() in snapshot.c

[Rafael J. Wysocki]

On Tue, Dec 12, 2023 at 3:38 PM <chenguanxi11234@xxxxxxx> wrote:
>
> What I've learned is that kmap_atomic() disables page-faults and
> preemption (the latter only for !PREEMPT_RT kernels).In my opinion,
> the code between the mapping and un-mapping in this patch does not
> depend on the above-mentioned side effects.So I simply replaced
> kmap_atomic() with kmap_local_page(). If I'm wrong, please explain it to me.

You are right, but why don't you say the above in the patch changelog
instead of the irrelevant information that is there now?