Re: [PATCH v6 1/2] dt-bindings: usb: Add the binding example for the Genesys Logic GL3523 hub

[Krzysztof Kozlowski]

On 12/12/2023 12:37, Anand Moon wrote:
> 
> Here is the list of warnings I observed with this patch
> 
>   DTC_CHK Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.example.dtb
> /home/amoon/mainline/linux-amlogic-6.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb:
> hub@1: 'vdd-supply' is a required property

You always require the property, but it is not valid for some devices.
Just require it only where it is applicable (in if:then: clause).


>         from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
> /home/amoon/mainline/linux-amlogic-6.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb:
> hub@1: 'reset-gpios' is a required property
>         from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
> /home/amoon/mainline/linux-amlogic-6.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb:
> hub@1: 'peer-hub' is a required property

...

>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - usb5e3,610
>>> +              - usb5e3,620
>>> +    then:
>>> +      properties:
>>> +        peer-hub: true
>>> +        vdd-supply: true
>>
>> Drop this if:, redundant.
>>
> No, this does not resolve the above issue.

It shouldn't resolve it, not related.


Best regards,
Krzysztof