Re: [PATCH v15 3/3] media: i2c: Add support for alvium camera

[Tommaso Merciai]

Hi Sakari,

On Tue, Dec 12, 2023 at 11:38:42AM +0000, Sakari Ailus wrote:
> Hi Tommaso,
> 
> On Mon, Dec 04, 2023 at 10:47:16AM +0100, Tommaso Merciai wrote:
> > The Alvium camera is shipped with sensor + isp in the same housing.
> > The camera can be equipped with one out of various sensor and abstract
> > the user from this. Camera is connected via MIPI CSI-2.
> > 
> > Most of the camera module features are supported, with the main exception
> > being fw update.
> > 
> > The driver provides all mandatory, optional and recommended V4L2 controls
> > for maximum compatibility with libcamera
> > 
> > References:
> >  - https://www.alliedvision.com/en/products/embedded-vision-solutions
> > 
> > Signed-off-by: Tommaso Merciai <tomm.merciai@xxxxxxxxx>
> 
> Could you run
> 
> 	./scripts/checkpatch.pl --strict --max-line-length=80
> 
> and address the issues in a patch on top of this set?
> 

Yes ofc.
You need also the following?

--- a/drivers/media/i2c/alvium-csi2.c
+++ b/drivers/media/i2c/alvium-csi2.c
@@ -2426,8 +2426,8 @@ static int alvium_probe(struct i2c_client *client)
                goto err_powerdown;

        if (!alvium_is_alive(alvium)) {
-               dev_err_probe(dev, ret, "Device detection failed\n");
                ret = -ENODEV;
+               dev_err_probe(dev, ret, "Device detection failed\n");
                goto err_powerdown;
        }

Let me know. Thanks for your work.


Regards,
Tommaso

> Thanks.
> 
> -- 
> Sakari Ailus