Re: [PATCH net-next 1/1] driver.h: add helper macro for module_exit() boilerplate

[Greg Kroah-Hartman]

On Tue, Dec 12, 2023 at 05:43:52PM +0800, Gan, Yi Fang wrote:
> For the modules need a module_init() but don't need to do
> anything special in module_exit() might need to have an empty
> module_exit(). This patch add a new macro module_exit_stub() to
> replace the empty module_exit(). The macro is useful to remove
> the module_exit() boilerplate.
> 
> Signed-off-by: Gan, Yi Fang <yi.fang.gan@xxxxxxxxx>
> ---
>  include/linux/device/driver.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Why would we take a macro that no one actually uses?

Please submit this with a user, you all know that this is the case, how
did it pass your internal reviews (hint, I don't think it did...)

thanks,

greg k-h