Re: [PATCH v6 20/40] mtd: rawnand: add support for ts72xx

[Nikita Shubin]

Hello Greg!

On Tue, 2023-12-12 at 09:30 +0100, Greg Kroah-Hartman wrote:
> On Tue, Dec 12, 2023 at 11:20:37AM +0300, Nikita Shubin via B4 Relay
> wrote:
> > From: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
> > 
> > Technologic Systems has it's own nand controller implementation in
> > CPLD.
> > 
> > Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
> > ---
> >  drivers/mtd/nand/raw/Kconfig                       |   7 +
> >  drivers/mtd/nand/raw/Makefile                      |   1 +
> >  drivers/mtd/nand/raw/technologic-nand-controller.c | 220
> > +++++++++++++++++++++
> >  3 files changed, 228 insertions(+)
> > 
> > diff --git a/drivers/mtd/nand/raw/Kconfig
> > b/drivers/mtd/nand/raw/Kconfig
> > index cbf8ae85e1ae..3937c10dea1c 100644
> > --- a/drivers/mtd/nand/raw/Kconfig
> > +++ b/drivers/mtd/nand/raw/Kconfig
> > @@ -449,6 +449,13 @@ config MTD_NAND_RENESAS
> >           Enables support for the NAND controller found on Renesas
> > R-Car
> >           Gen3 and RZ/N1 SoC families.
> >  
> > +config MTD_NAND_TS72XX
> > +       tristate "ts72xx NAND controller"
> > +       depends on ARCH_EP93XX && HAS_IOMEM
> > +       help
> > +         Enables support for NAND controller on ts72xx SBCs.
> > +         This is a legacy driver based on gen_nand.
> 
> Why is a new "legacy driver" being written these days?  Why not do it
> properly?

Sorry, my bad, description is a leftover from older description (when i
was allowed to submit a legacy one).

The driver is mostly new, shiny and approved by Miquel:

https://lore.kernel.org/lkml/20231004103911.2aa65354@xps-13/

The KConfig description should be fixed.

> 
> thanks,
> 
> greg k-h