RE: [PATCH 2/2] cdx: Explicitly include correct DT includes, again

From: Agarwal, Nikhil
Date: Mon Dec 11 2023 - 23:44:56 EST


> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Thursday, December 7, 2023 10:01 PM
> To: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Gupta, Nipun
> <Nipun.Gupta@xxxxxxx>; Agarwal, Nikhil <nikhil.agarwal@xxxxxxx>;
> Gangurde, Abhijit <abhijit.gangurde@xxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH 2/2] cdx: Explicitly include correct DT includes, again
>
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it was merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h and
> of.h. As a result, there's a pretty much random mix of those include files used
> throughout the tree. In order to detangle these headers and replace the
> implicit includes with struct declarations, users need to explicitly include the
> correct includes.
>
> CDX was fixed once, but commit ("cdx: Remove cdx controller list from cdx bus
> system") added another occurrence.
>
> Fixes: 54b406e10f03 ("cdx: Remove cdx controller list from cdx bus system")
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

Acked-by: Nikhil Agarwal <Nikhil.agarwal@xxxxxxx>