RE: [PATCH] extcon: qcom-spmi-misc: don't use kernel-doc marker for comment

From: Chanwoo Choi
Date: Mon Dec 11 2023 - 19:34:51 EST




> -----Original Message-----
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Sent: Wednesday, December 6, 2023 8:12 AM
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>; Andy Gross <agross@xxxxxxxxxx>;
> Bjorn Andersson <andersson@xxxxxxxxxx>; Konrad Dybcio
> <konrad.dybcio@xxxxxxxxxx>; MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>;
Chanwoo
> Choi <cw00.choi@xxxxxxxxxxx>
> Subject: [PATCH] extcon: qcom-spmi-misc: don't use kernel-doc marker for
> comment
>
> Do not use "/**" for non-kernel-doc comments. This prevents a warning from
> scripts/kernel-doc:
>
> warning: expecting prototype for extcon(). Prototype was for
> USB_ID_DEBOUNCE_MS() instead
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Andy Gross <agross@xxxxxxxxxx>
> Cc: Bjorn Andersson <andersson@xxxxxxxxxx>
> Cc: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> ---
> drivers/extcon/extcon-qcom-spmi-misc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/extcon/extcon-qcom-spmi-misc.c b/drivers/extcon/extcon-
> qcom-spmi-misc.c
> --- a/drivers/extcon/extcon-qcom-spmi-misc.c
> +++ b/drivers/extcon/extcon-qcom-spmi-misc.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/**
> +/*
> * extcon-qcom-spmi-misc.c - Qualcomm USB extcon driver to support USB ID
> * and VBUS detection based on extcon-usb-gpio.c.
> *

Applied it. Thanks.

Best Regards,
Chanwoo Choi