Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test

[John Hubbard]

On 12/11/23 12:01, Mark Brown wrote:
> On Mon, Dec 11, 2023 at 07:00:32PM +0100, David Hildenbrand wrote:
> > On 11.12.23 18:32, Mark Brown wrote:
> > > On Mon, Dec 11, 2023 at 05:53:59PM +0100, David Hildenbrand wrote:
>
> > > > https://lkml.kernel.org/r/20231209020144.244759-1-jhubbard@xxxxxxxxxx
>
> > > I mean, I guess people who don't want to install the headers are just
> > > not going to be able to build a bunch of tests?  There definitely are a
> > > bunch of tests where it's not needed so I can see why people would not
> > > like being forced to do the headers step if they're only interested in
> > > those tests.
>
> > Yes. And before that, people mostly had no clue that headers had to be
> > installed in order to compile successfully.
>
> > So maybe a warning to give at least some hint might be reasonable.
>
> That sounds sensible, especially if we could arrange to flag when the
> specific tests being built need it.


But the end result is messy: not everything builds in some cases. If
instead we went back to the little ifdef snippets, such as this (from
v5.1):

hugepage-shm.c:

    #ifndef SHM_HUGETLB
    #define SHM_HUGETLB 04000
    #endif

...then with a bit of one-time, manual effort, we could get everything
to work at all times. And that seems better, doesn't it?


thanks,
--
John Hubbard
NVIDIA