Re: [PATCH 2/2] md: don't account sync_io if iostats of the disk is disabled

From: kernel test robot
Date: Mon Dec 11 2023 - 13:00:39 EST

Next message: David Hildenbrand: "Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test"
Previous message: Bart Van Assche: "Re: [PATCH] scsi: ufs: qcom: Perform read back after writing reset bit"
In reply to: linan666: "[PATCH 2/2] md: don't account sync_io if iostats of the disk is disabled"
Next in thread: kernel test robot: "Re: [PATCH 2/2] md: don't account sync_io if iostats of the disk is disabled"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on song-md/md-next]
[also build test ERROR on axboe-block/for-next linus/master v6.7-rc5 next-20231211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/linan666-huaweicloud-com/md-Fix-overflow-in-is_mddev_idle/20231211-155833
base: git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next
patch link: https://lore.kernel.org/r/20231211075614.1850003-3-linan666%40huaweicloud.com
patch subject: [PATCH 2/2] md: don't account sync_io if iostats of the disk is disabled
config: i386-buildonly-randconfig-003-20231211 (https://download.01.org/0day-ci/archive/20231212/202312120159.I03ON8Ov-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231212/202312120159.I03ON8Ov-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312120159.I03ON8Ov-lkp@xxxxxxxxx/

All error/warnings (new ones prefixed by >>):

In file included from drivers/md/md-faulty.c:60:
>> drivers/md/md.h:587:28: error: character <U+2014> not allowed in an identifier
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
11 errors generated.
--
In file included from drivers/md/md-bitmap.c:32:
>> drivers/md/md.h:587:28: error: character <U+2014> not allowed in an identifier
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md-bitmap.c:2601:34: warning: result of comparison of constant 4294967296 with expression of type 'unsigned long' is always false [-Wtautological-constant-out-of-range-compare]
if (BITS_PER_LONG > 32 && csize >= (1ULL << (BITS_PER_BYTE *
~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 11 errors generated.
--
In file included from drivers/md/md.c:69:
>> drivers/md/md.h:587:28: error: character <U+2014> not allowed in an identifier
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.c:8517:29: error: character <U+2014> not allowed in an identifier
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.c:8517:25: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.c:8517:33: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.c:8517:25: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.c:8517:33: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.c:8517:25: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.c:8517:33: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.c:8517:25: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
--
In file included from drivers/md/raid5.c:53:
>> drivers/md/md.h:587:28: error: character <U+2014> not allowed in an identifier
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:24: error: use of undeclared identifier 'disk—'
if (blk_queue_io_stat(disk—>queue))
^
>> drivers/md/md.h:587:32: error: use of undeclared identifier 'queue'
if (blk_queue_io_stat(disk—>queue))
^
drivers/md/raid5.c:4265:7: warning: variable 'qread' set but not used [-Wunused-but-set-variable]
int qread =0;
^
1 warning and 11 errors generated.

vim +587 drivers/md/md.h

584
585 static inline void md_sync_acct_bio(struct bio *bio, unsigned long nr_sectors)
586 {
> 587 if (blk_queue_io_stat(disk—>queue))
588 md_sync_acct(bio->bi_bdev, nr_sectors);
589 }
590

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Next message: David Hildenbrand: "Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test"
Previous message: Bart Van Assche: "Re: [PATCH] scsi: ufs: qcom: Perform read back after writing reset bit"
In reply to: linan666: "[PATCH 2/2] md: don't account sync_io if iostats of the disk is disabled"
Next in thread: kernel test robot: "Re: [PATCH 2/2] md: don't account sync_io if iostats of the disk is disabled"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]