Re: [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY

From: Dmitry Baryshkov
Date: Mon Dec 11 2023 - 12:39:43 EST


On Mon, 11 Dec 2023 at 19:24, Manivannan Sadhasivam
<manivannan.sadhasivam@xxxxxxxxxx> wrote:
>
> While convering the binding to new format, serdes address specified in the
> old binding was used as the base address. This causes a boot hang as the
> driver tries to access memory region outside of the specified address. Fix
> it!
>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # 6.6
> Fixes: bb56cff4ac03 ("ARM: dts: qcom-sdx55: switch PCIe QMP PHY to new style of bindings")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

> ---
> arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> index 2aa5089a8513..a88f186fcf03 100644
> --- a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> @@ -436,9 +436,9 @@ pcie_ep: pcie-ep@1c00000 {
> status = "disabled";
> };
>
> - pcie_phy: phy@1c07000 {
> + pcie_phy: phy@1c06000 {
> compatible = "qcom,sdx55-qmp-pcie-phy";
> - reg = <0x01c07000 0x2000>;
> + reg = <0x01c06000 0x2000>;
> #address-cells = <1>;
> #size-cells = <1>;
> ranges;
> --
> 2.25.1
>


--
With best wishes
Dmitry