Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE

[Conor Dooley]

On Mon, Dec 11, 2023 at 02:36:11PM +0100, Nam Cao wrote:
> On Tue, 28 Nov 2023 10:59:44 +0000 Conor Dooley <conor.dooley@xxxxxxxxxxxxx> wrote:
> > On Tue, Nov 28, 2023 at 11:27:22AM +0100, Nam Cao wrote:
> > > On Thu, May 25, 2023 at 02:18:36PM +0800, Jia Jie Ho wrote:  
> > > > Selects ARM_AMBA platform support for StarFive SoCs required by spi and
> > > > crypto dma engine.
> > > > 
> > > > Signed-off-by: Jia Jie Ho <jiajie.ho@xxxxxxxxxxxxxxxx>
> > > > ---
> > > >  arch/riscv/Kconfig.socs | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> > > > index 1cf69f958f10..381cd46e6373 100644
> > > > --- a/arch/riscv/Kconfig.socs
> > > > +++ b/arch/riscv/Kconfig.socs
> > > > @@ -29,6 +29,7 @@ config SOC_STARFIVE
> > > >  	bool "StarFive SoCs"
> > > >  	select PINCTRL
> > > >  	select RESET_CONTROLLER
> > > > +	select ARM_AMBA
> > > >  	help
> > > >  	  This enables support for StarFive SoC platform hardware.  
> > > 
> > > I'm considering sending this to stable trees. Without this, it is not
> > > possible to configure the kernel with SPI driver for the starfive board.
> > > 
> > > I just want to check with you first, in case I miss something obvious.
> > > Any objection to backporting this patch?  
> > 
> > Personally I would be okay with that, otherwise the driver is dead code
> > in those stable versions. Just be sure that the rename of some pl011
> > variables (I think that's what it was) that was a pre-req for this being
> > merged is in said versions of stable. An allmodconfig should flag
> > whether that has happened pretty quickly.
> 
> Thanks for the info. I think I found what you are talking about:
> a1a5f2c88725 ("dmaengine: pl330: rename _start to prevent build error")
> 
> It's been a while and no one else said anything, so I am going forward with
> this.

Yeah, that's the one. Sorry that I did not recall correctly.

Attachment: signature.asc
Description: PGP signature