Re: [RFC, PATCH 1/2] ASoC: qcom: sdw: Add TDM support

From: Jianhua Lu
Date: Mon Dec 11 2023 - 08:40:23 EST


On Mon, Dec 11, 2023 at 01:20:25PM +0000, Mark Brown wrote:
> On Mon, Dec 11, 2023 at 05:53:56PM +0800, Jianhua Lu wrote:
>
> > + }
> > +}
> > +EXPORT_SYMBOL_GPL(qcom_snd_tdm_hw_params);
> > +
>
> Why is this exported?

Thanks for spotting it, I will drop it in patch v2.
>
> > @@ -125,6 +186,9 @@ int qcom_snd_sdw_hw_params(struct snd_pcm_substream *substream,
> > *psruntime = sruntime;
> > }
> > break;
> > + case PRIMARY_TDM_RX_0...QUINARY_TDM_TX_7:
> > + qcom_snd_tdm_hw_params(substream, params);
> > + break;
> > }
>
> The only caller is in the same file.