Re: [PATCH v3 0/5] TPMI update for permissions

From: Hans de Goede
Date: Mon Dec 11 2023 - 05:08:59 EST


Hi,

On 12/4/23 23:17, Srinivas Pandruvada wrote:
> Process read/write and enabled state for feature drivers. When a feature
> is disabled, don't create a device to load a feature driver. When a read
> is blocked then don't load feature drivers. When write is blocked continue
> to function in read only mode.

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans







> v3:
> No code change. Rebased on top of
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86 review-hans
>
> v2:
> Dropped patch platform/x86/intel/tpmi: Add additional TPMI header fields
> Addressed other review comments, details are in each patch
>
> Srinivas Pandruvada (5):
> platform/x86/intel/tpmi: Don't create devices for disabled features
> platform/x86/intel/tpmi: Modify external interface to get read/write
> state
> platform/x86/intel/tpmi: Move TPMI ID definition
> platform/x86: ISST: Process read/write blocked feature status
> platform/x86/intel-uncore-freq: Process read/write blocked feature
> status
>
> .../intel/speed_select_if/isst_tpmi_core.c | 25 +++++++++++++
> drivers/platform/x86/intel/tpmi.c | 35 +++++++++----------
> .../uncore-frequency/uncore-frequency-tpmi.c | 15 ++++++++
> include/linux/intel_tpmi.h | 18 ++++++++--
> 4 files changed, 72 insertions(+), 21 deletions(-)
>