Re:Re: [PATCH v2 4/5] dt-bindings: arm: rockchip: Add Cool Pi CM5 EVB

[Andy Yan]

Hi Krzysztof：

At 2023-12-10 19:11:33, "Krzysztof Kozlowski" <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>On 10/12/2023 09:06, Andy Yan wrote:
>> Add Cool Pi CM5 EVB, a board powered by RK3588
>> 
>> Signed-off-by: Andy Yan <andyshrk@xxxxxxx>
>> 
>> ---
>> 
>> Changes in v2:
>> - change board compatible from "CoolPi CM5 EVB" to "coolpi,pi-cm5-evb"
>> 
>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 11d03035f3db..4da83bbd642a 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -95,6 +95,11 @@ properties:
>>            - const: chipspark,rayeager-px2
>>            - const: rockchip,rk3066a
>>  
>> +      - description: Cool Pi Compute Module 5(CM5) EVB
>> +        items:
>> +          - const: coolpi,pi-cm5-evb
>
>If it is module you are maybe missing here module DTSI and compatible.
>

Yes， it is a core board（CM5） + mother board = CM5 EVB，this is
the  variant I current have， I want to keep the dts as it is now，I will
convert it to a dtsi when I get another variant for this core board（CM5）.

>Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
>Best regards,
>Krzysztof
>
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel