Re: [PATCH v3 4/4] pinctrl: samsung: add exynosautov920 pinctrl

[Jaewon Kim]

Hello Krzysztof,

Thanks for your review.


On 23. 12. 10. 22:23, Krzysztof Kozlowski wrote:
> On 08/12/2023 08:45, Jaewon Kim wrote:
>> Add pinctrl data for ExynosAutov920 SoC.
>>
>> Pinctrl data for ExynosAutoV920 SoC.
>>   - GPA0,GPA1 (10): External wake up interrupt
>>   - GPQ0 (2): SPMI (PMIC I/F)
>>   - GPB0,GPB1,GPB2,GPB3,GPB4,GPB5,GPB6 (47): I2S Audio
>>   - GPH0,GPH1,GPH2,GPH3,GPH4,GPH5,GPH6,GPH8 (49): PCIE, UFS, Ethernet
>>   - GPG0,GPG1,GPG2,GPG3,GPG4,GPG5 (29): General purpose
>>   - GPP0,GPP1,GPP2,GPP3,GPP4,GPP5,GPP6,GPP7,GPP8,GPP9,GPP10 (77): USI
>>
>> Signed-off-by: Jaewon Kim <jaewon02.kim@xxxxxxxxxxx>
>> ---
> ...
>
>
>>   /**
>>    * struct exynos_weint_data: irq specific data for all the wakeup interrupts
>>    * generated by the external wakeup interrupt controller.
>> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
>> index 362e99566919..800a2f0a026a 100644
>> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
>> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
>> @@ -1324,6 +1324,8 @@ static const struct of_device_id samsung_pinctrl_dt_match[] = {
>>   		.data = &exynosautov9_of_data },
>>   	{ .compatible = "tesla,fsd-pinctrl",
>>   		.data = &fsd_of_data },
>> +	{ .compatible = "samsung,exynosautov920-pinctrl",
>> +		.data = &exynosautov920_of_data },
> Please put it after autov9.

Okay, I will change the order.

>
> Best regards,
> Krzysztof
>
>
>

Thanks

Jaewon Kim