Re: [syzbot] [arm-msm?] [net?] memory leak in radix_tree_insert

From: syzbot
Date: Sat Dec 09 2023 - 20:04:27 EST


For archival purposes, forwarding an incoming command email to
linux-kernel@xxxxxxxxxxxxxxx.

***

Subject: [arm-msm?] [net?] memory leak in radix_tree_insert
Author: eadavis@xxxxxx

please test memory leak in radix_tree_insert

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 33cc938e65a9

diff --git a/net/qrtr/af_qrtr.c b/net/qrtr/af_qrtr.c
index 41ece61eb57a..3d06156fe913 100644
--- a/net/qrtr/af_qrtr.c
+++ b/net/qrtr/af_qrtr.c
@@ -275,6 +275,8 @@ static int qrtr_tx_wait(struct qrtr_node *node, int dest_node, int dest_port,
if (flow) {
init_waitqueue_head(&flow->resume_tx);
if (radix_tree_insert(&node->qrtr_tx_flow, key, flow)) {
+ printk("f: %p\n", flow);
+ radix_tree_delete(&node->qrtr_tx_flow, key);
kfree(flow);
flow = NULL;
}
@@ -287,10 +289,14 @@ static int qrtr_tx_wait(struct qrtr_node *node, int dest_node, int dest_port,
return 1;

spin_lock_irq(&flow->resume_tx.lock);
+ printk("to wait, f: %p, pd: %d, ff: %d, ep: %p\n",
+ flow, flow->pending, flow->tx_failed, node->ep);
ret = wait_event_interruptible_locked_irq(flow->resume_tx,
flow->pending < QRTR_TX_FLOW_HIGH ||
flow->tx_failed ||
!node->ep);
+ printk("r: %d, f: %p, pd: %d, ff: %d, ep: %p\n",
+ ret, flow, flow->pending, flow->tx_failed, node->ep);
if (ret < 0) {
confirm_rx = ret;
} else if (!node->ep) {