Re: [PATCH v2 11/11] mm/mempolicy: extend set_mempolicy2 and mbind2 to support weighted interleave
From: kernel test robot
Date: Sat Dec 09 2023 - 17:34:18 EST
Hi Gregory,
kernel test robot noticed the following build warnings:
[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on deller-parisc/for-next powerpc/next powerpc/fixes s390/features jcmvbkbc-xtensa/xtensa-for-next arnd-asm-generic/master linus/master v6.7-rc4]
[cannot apply to tip/x86/asm geert-m68k/for-next geert-m68k/for-linus next-20231208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Gregory-Price/mm-mempolicy-implement-the-sysfs-based-weighted_interleave-interface/20231209-150314
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20231209065931.3458-12-gregory.price%40memverge.com
patch subject: [PATCH v2 11/11] mm/mempolicy: extend set_mempolicy2 and mbind2 to support weighted interleave
config: x86_64-randconfig-123-20231210 (https://download.01.org/0day-ci/archive/20231210/202312100606.2aOpv2T5-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231210/202312100606.2aOpv2T5-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312100606.2aOpv2T5-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
mm/mempolicy.c: note: in included file (through include/linux/rculist.h, include/linux/pid.h, include/linux/sched.h, ...):
include/linux/rcupdate.h:778:9: sparse: sparse: context imbalance in 'queue_folios_pte_range' - unexpected unlock
mm/mempolicy.c: note: in included file (through arch/x86/include/asm/uaccess.h, include/linux/uaccess.h, include/linux/sched/task.h, ...):
arch/x86/include/asm/uaccess_64.h:88:24: sparse: sparse: cast removes address space '__user' of expression
>> mm/mempolicy.c:1681:29: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected unsigned char *weights_ptr @@ got void [noderef] __user * @@
mm/mempolicy.c:1681:29: sparse: expected unsigned char *weights_ptr
mm/mempolicy.c:1681:29: sparse: got void [noderef] __user *
>> mm/mempolicy.c:1684:45: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void const [noderef] __user *src @@ got unsigned char *weights_ptr @@
mm/mempolicy.c:1684:45: sparse: expected void const [noderef] __user *src
mm/mempolicy.c:1684:45: sparse: got unsigned char *weights_ptr
mm/mempolicy.c:2042:29: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected unsigned char *weights_ptr @@ got void [noderef] __user * @@
mm/mempolicy.c:2042:29: sparse: expected unsigned char *weights_ptr
mm/mempolicy.c:2042:29: sparse: got void [noderef] __user *
>> mm/mempolicy.c:2043:36: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *to @@ got unsigned char *weights_ptr @@
mm/mempolicy.c:2043:36: sparse: expected void [noderef] __user *to
mm/mempolicy.c:2043:36: sparse: got unsigned char *weights_ptr
vim +1681 mm/mempolicy.c
1629
1630 SYSCALL_DEFINE5(mbind2, const struct iovec __user *, vec, size_t, vlen,
1631 const struct mpol_args __user *, uargs, size_t, usize,
1632 unsigned long, flags)
1633 {
1634 struct mpol_args kargs;
1635 struct mempolicy_args margs;
1636 nodemask_t policy_nodes;
1637 unsigned long __user *nodes_ptr;
1638 struct iovec iovstack[UIO_FASTIOV];
1639 struct iovec *iov = iovstack;
1640 struct iov_iter iter;
1641 unsigned char weights[MAX_NUMNODES];
1642 unsigned char *weights_ptr;
1643 int err;
1644
1645 if (!vec || !vlen)
1646 return -EINVAL;
1647
1648 err = copy_struct_from_user(&kargs, sizeof(kargs), uargs, usize);
1649 if (err)
1650 return -EINVAL;
1651
1652 err = validate_mpol_flags(kargs.mode, &kargs.mode_flags);
1653 if (err)
1654 return err;
1655
1656 margs.mode = kargs.mode;
1657 margs.mode_flags = kargs.mode_flags;
1658 margs.addr = kargs.addr;
1659
1660 /* if home node given, validate it is online */
1661 if (flags & MPOL_MF_HOME_NODE) {
1662 if ((kargs.home_node >= MAX_NUMNODES) ||
1663 !node_online(kargs.home_node))
1664 return -EINVAL;
1665 margs.home_node = kargs.home_node;
1666 } else
1667 margs.home_node = NUMA_NO_NODE;
1668 flags &= ~MPOL_MF_HOME_NODE;
1669
1670 if (kargs.pol_nodes) {
1671 nodes_ptr = u64_to_user_ptr(kargs.pol_nodes);
1672 err = get_nodes(&policy_nodes, nodes_ptr,
1673 kargs.pol_maxnodes);
1674 if (err)
1675 return err;
1676 margs.policy_nodes = &policy_nodes;
1677 } else
1678 margs.policy_nodes = NULL;
1679
1680 if (kargs.mode == MPOL_WEIGHTED_INTERLEAVE) {
> 1681 weights_ptr = u64_to_user_ptr(kargs.il_weights);
1682 err = copy_struct_from_user(&weights,
1683 sizeof(weights),
> 1684 weights_ptr,
1685 kargs.pol_maxnodes);
1686 if (err)
1687 return err;
1688 margs.il_weights = weights;
1689 } else {
1690 margs.il_weights = NULL;
1691 flags |= MPOL_F_GWEIGHT;
1692 }
1693
1694 /* For each address range in vector, do_mbind */
1695 err = import_iovec(ITER_DEST, vec, vlen, ARRAY_SIZE(iovstack), &iov,
1696 &iter);
1697 if (err)
1698 return err;
1699 while (iov_iter_count(&iter)) {
1700 unsigned long start, len;
1701
1702 start = untagged_addr((unsigned long)iter_iov_addr(&iter));
1703 len = iter_iov_len(&iter);
1704 err = do_mbind(start, len, &margs, flags);
1705 if (err)
1706 break;
1707 iov_iter_advance(&iter, iter_iov_len(&iter));
1708 }
1709
1710 kfree(iov);
1711 return err;
1712 }
1713
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki