Re: [PATCH v1] i2c: cadence: Add system suspend and resume PM support

[Ji Sheng Teoh]

On Sat, 9 Dec 2023 14:01:40 +0100
Andi Shyti <andi.shyti@xxxxxxxxxx> wrote:

> Hi Ji Sheng,
> 
> [...]
> 
> > +static int __maybe_unused cdns_i2c_resume(struct device *dev)
> > +{
> > +	struct cdns_i2c *xi2c = dev_get_drvdata(dev);
> > +	int err;
> > +
> > +	err = cdns_i2c_runtime_resume(dev);
> > +	if (err)
> > +		return err;
> > +
> > +	if (pm_runtime_status_suspended(dev)) {
> > +		cdns_i2c_runtime_suspend(dev);
> > +		if (err)
> > +			return err;  
> 
> have you forgotten to assign 'err'?
> 
> Andi
> 
> > +	}  

My bad, I will fix it in v2. Thanks Andi.