Re: [PATCH 1/2] dt-bindings: serial: rs485: add rs485-mux-gpios binding

[Lino Sanfilippo]

On 06.12.23 16:42, Lino Sanfilippo wrote:
>

>>>>
>>>> Crescent CY Hsieh (+cc) is in parallel trying to add an RS-422 mode bit
>>>> to struct serial_rs485:
>>>>
>>>> https://lore.kernel.org/all/20231121095122.15948-1-crescentcy.hsieh@xxxxxxxx/
>>>>
>>>
>>> That new flag was suggested by me instead of using SER_RS422_ENABLED, which
>>> would mostly be redundant to SER_RS485_ENABLED.

A cleaner solution would probably be to not handle RS422 with the RS485 settings at
all, but to introduce another set of ioctls to set and read it.

An own RS422 structure like

struct serial_rs422 {
	__u32	flags;
#define SER_RS422_ENABLED		(1 << 0)
#define SER_RS422_TERMINATE_BUS		(1 << 1)
};


could be used as the parameter for these new ioctls.

Any comments on this?


Regards,
Lino