Re: [PATCH] KVM: selftests: fix supported_flags for aarch64

From: Sean Christopherson
Date: Fri Dec 08 2023 - 21:48:49 EST


On Fri, Dec 08, 2023, Paolo Bonzini wrote:
> KVM/Arm supports readonly memslots; fix the calculation of
> supported_flags in set_memory_region_test.c, otherwise the
> test fails.

You got beat by a few hours, and by a better solution ;-)

https://lore.kernel.org/all/20231208033505.2930064-1-shahuang@xxxxxxxxxx

> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> ---
> tools/testing/selftests/kvm/set_memory_region_test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/set_memory_region_test.c b/tools/testing/selftests/kvm/set_memory_region_test.c
> index 6637a0845acf..dfd1d1e22da3 100644
> --- a/tools/testing/selftests/kvm/set_memory_region_test.c
> +++ b/tools/testing/selftests/kvm/set_memory_region_test.c
> @@ -333,9 +333,11 @@ static void test_invalid_memory_region_flags(void)
> struct kvm_vm *vm;
> int r, i;
>
> -#ifdef __x86_64__
> +#if defined __aarch64__ || defined __x86_64__
> supported_flags |= KVM_MEM_READONLY;
> +#endif
>
> +#ifdef __x86_64__
> if (kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(KVM_X86_SW_PROTECTED_VM))
> vm = vm_create_barebones_protected_vm();
> else
> --
> 2.39.1
>