Re: [PATCH v4 10/17] dt-bindings: display: vop2: Add rk3588 support

From: Andy Yan
Date: Fri Dec 08 2023 - 20:40:22 EST


HI Krzysztof:

On 12/9/23 01:46, Krzysztof Kozlowski wrote:
On 07/12/2023 09:01, Andy Yan wrote:
From: Andy Yan <andy.yan@xxxxxxxxxxxxxx>

The vop2 on rk3588 is similar to which on rk356x
but with 4 video ports and need to reference
more grf modules.

Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>

---

Changes in v4:
- drop redundant description.
- use full stop at all the description's end.
- address Krzysztof's review in v3

What changed? Please list specific changes, not just generic "address
review".


Sorry, I will keep this in mind in the future.


Changes in v3:
- constrain properties in allOf:if:then
- some description updates


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

---

This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip