Re: [PATCH v4 00/17] Add VOP2 support on rk3588

[Andy Yan]

Hi Heiko:

On 12/9/23 00:07, Heiko Stübner wrote:
> Hi Andy,
>
> Am Donnerstag, 7. Dezember 2023, 08:59:06 CET schrieb Andy Yan:
> > From: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
> >
> > This patch sets aims at enable the VOP2 support on rk3588.
> >
> > Main feature of VOP2 on rk3588:
> > Four video ports:
> > VP0 Max 4096x2160
> > VP1 Max 4096x2160
> > VP2 Max 4096x2160
> > VP3 Max 2048x1080
> >
> > 4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
> > 4 4K Esmart windows with line RGB/YUV support
> >
> > The current version support all the 8 windows with all the suppported
> > plane format.
> >
> > And we don't have a upstreamed encoder/connector(HDMI/DP) for rk3588
> > yet, Cristian from collabora is working on adding upstream support for
> > HDMI on rk3588.
> >
> > My current test(1080P/4KP60) is runing with a HDMI driver pick from
> > downstream bsp kernel.
> >
> > A branch based on linux-6.7 rc4 containing all the series and
> > HDMI driver(not compatible with mainline rk3568 hdmi) picked
> > from downstream bsp kernel is available [0].
> >
> > [0]https://github.com/andyshrk/linux/commits/rk3588-vop2-upstream-linux-6.7-rc4-2023-12-07
> >
> > Changes in v4:
> > - fix the POST_BUF_EMPTY irq when set mode
> > - use full stop at all the description's end.
> > - address Krzysztof's review about dt-binding in v3
> > - keep all VOP2_FEATURE_HAS_xxx macros increase in order.
> > - address Sascha's review about debugfs
> > - Add const for rockchip,rk3588-iommu compatible
>
> very nice, the error messages on "mode changes" are gone now.
> Display and even combination with panthor still work of my rk3588-board
>
> Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>

Thanks for your honorable work on this platform, and thanks for you test and review.

So can I add your Tested-by for all this series form PATCH 1~16 in next version?
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-rockchip