Re: [PATCH 1/2] VMCI: Remove handle_arr_calc_size()

[Christophe JAILLET]

Le 08/12/2023 à 21:59, Kees Cook a écrit :
> On Fri, Dec 08, 2023 at 09:46:09PM +0100, Christophe JAILLET wrote:
> > Use struct_size() instead of handle_arr_calc_size().
> > This is much more conventionnal.
> >
> > Suggested-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>
> Looks good. And since capacity in u32, there's no need for size_add().

Hmm,

isn't u32 + u32 --> u32, so can overflow?
If I understand correctly, the type promotion to size_t will occur after 
the addition.

So size_add() looks needed, or I missed something?

CJ

> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>