Re: [PATCH v2 0/3] Moxtet bus fixes

From: Gregory CLEMENT
Date: Fri Dec 08 2023 - 09:52:24 EST


Hello Marek and Sjoerd,

> It seems the moxtet bus support was broken since 21aad8ba615e ("arm64:
> dts: armada-3720-turris-mox: Add missing interrupt for RTC") for two
> reasons:
> * The moxtet irq isn't marked as shared so the driver fails to load if
> the rtc driver gets set up first.
> * The dts change didn't set the IRQ type, so in case the rtc driver got
> probed first irq setup ended up wrong (rising instead of falling edge).
>
> On top of that the moxtet module isn't auto-loading due to a missing spi
> table
>
> Changes in v2:
> - Add cover letter
> - Add patch to set the irq type
>
> Sjoerd Simons (3):
> bus: moxtet: Mark the irq as shared
> bus: moxtet: Add spi device table
> arm64: dts: armada-3720-turris-mox: set irq type for RTC

I only received the previous patch in my inbox, I plan to apply it. But
what about the 2 other patches ? Marek will you do a pull request with
these 2 patches or do you expect that I take them also ?

Regards,

Gregory


>
> arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +-
> drivers/bus/moxtet.c | 9 ++++++++-
> 2 files changed, 9 insertions(+), 2 deletions(-)
>
> --
> 2.43.0
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com