Re: [PATCH 1/3] PCI/AER: Use 'Correctable' and 'Uncorrectable' spec terms for errors

From: Jonathan Cameron
Date: Fri Dec 08 2023 - 09:36:22 EST


On Wed, 6 Dec 2023 16:42:29 -0600
Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:

> From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>
> The PCIe spec classifies errors as either "Correctable" or "Uncorrectable".
> Previously we printed these as "Corrected" or "Uncorrected". To avoid
> confusion, use the same terms as the spec.
>
> One confusing situation is when one agent detects an error, but another
> agent is responsible for recovery, e.g., by re-attempting the operation.
> The first agent may log a "correctable" error but it has not yet been
> corrected. The recovery agent must report an uncorrectable error if it is
> unable to recover. If we print the first agent's error as "Corrected", it
> gives the false impression that it has already been resolved.
>
> Sample message change:
>
> - pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5
> + pcieport 0000:00:1c.5: AER: Correctable error received: 0000:00:1c.5
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx
Good to tidy this up. FWIW
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>