Re: [PATCH 4/5] platform/x86: wmi: Remove chardev interface

From: Ilpo Järvinen
Date: Fri Dec 08 2023 - 08:43:32 EST


On Thu, 7 Dec 2023, Armin Wolf wrote:

> The design of the WMI chardev interface is broken:
> - it assumes that WMI drivers are not instantiated twice
> - it offers next to no abstractions, the WMI driver gets
> a raw byte buffer
> - it is only used by a single driver, something which is
> unlikely to change
>
> Since the only user (dell-smbios-wmi) has been migrated
> to his own ioctl interface, remove it.
>
> Signed-off-by: Armin Wolf <W_Armin@xxxxxx>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

--
i.