Re: [PATCH 0/3] nfsd: fully close all files in the nfsd threads

From: Jeff Layton
Date: Fri Dec 08 2023 - 06:42:50 EST


On Fri, 2023-12-08 at 14:27 +1100, NeilBrown wrote:
> This is a new version of my patches to address a rare problem with nfsd
> closing files faster than __fput() can complete the close in a different
> thread.
>
> This time I'm simply switching to __fput_sync(). I cannot see any
> reason that this would be a problem, but if any else does and can show
> me what I'm missing, I'd appreciate it.
>
> Thanks,
> NeilBrown
>
>
> [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of
> [PATCH 2/3] nfsd: Don't leave work of closing files to a work queue.
> [PATCH 3/3] VFS: don't export flush_delayed_fput().

Looks good to me.

Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>