Re: [PATCH net-next v6 08/12] libie: add Rx buffer management (via Page Pool)

From: Yunsheng Lin
Date: Fri Dec 08 2023 - 06:28:56 EST


On 2023/12/8 17:28, Yunsheng Lin wrote:

>> +
>> + page_pool_dma_sync_for_cpu(page->pp, page, buf->offset, len);
>
> Is there a reason why page_pool_dma_sync_for_cpu() is still used when
> page_pool_create() is called with PP_FLAG_DMA_SYNC_DEV flag? Isn't syncing
> already handled in page_pool core when when PP_FLAG_DMA_SYNC_DEV flag is
> set?

Ah, it is a sync_for_cpu.
Ignore this one.