Re: [PATCH v2] drm/modes: replace deprecated strncpy with strscpy_pad

From: Kees Cook
Date: Thu Nov 30 2023 - 17:01:07 EST


On Mon, 16 Oct 2023 22:38:20 +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We should NUL-pad as there are full struct copies happening in places:
> | struct drm_mode_modeinfo umode;
> |
> | ...
> | struct drm_property_blob *blob;
> |
> | drm_mode_convert_to_umode(&umode, mode);
> | blob = drm_property_create_blob(crtc->dev,
> | sizeof(umode), &umode);
>
> [...]

Applied to for-next/hardening, thanks!

[1/1] drm/modes: replace deprecated strncpy with strscpy_pad
https://git.kernel.org/kees/c/d8d273c595db

Take care,

--
Kees Cook